Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of arguments path and ase_atoms_list was switched in Dataset #161

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Order of arguments path and ase_atoms_list was switched in Dataset #161

merged 2 commits into from
Feb 6, 2024

Conversation

marcoscaa
Copy link

Summary

Two minor changes in dataset.py. Order of arguments given to add_from_ase and _read_from_ase was switched in two cases:

  • Dataset.from_ase: instance.add_from_ase(...)
  • Dataset.add_from_ase: self._read_from_ase(...)

@mjwen
Copy link
Collaborator

mjwen commented Feb 6, 2024

Thanks @marcoscaa!

@mjwen mjwen merged commit 6f9388b into openkim:v1 Feb 6, 2024
4 checks passed
@mjwen mjwen mentioned this pull request Feb 9, 2024
Merged
@mjwen mjwen added the fix label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoscaa @mjwen