Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: touchend crash caused by bridge #307 #320

Merged
merged 1 commit into from
May 14, 2021
Merged

fix: touchend crash caused by bridge #307 #320

merged 1 commit into from
May 14, 2021

Conversation

airingursb
Copy link
Member

  1. bridge 注册 cancel 事件:handleMouseEvent 传 cancel 事件时会导致 crash,使用 touchend 时真机更容易复现 监听touch事件改变元素位置,程序闪退 #307
  2. 增加 touch event 测试用例

1. bridge 注册 cancel 事件:handleMouseEvent 传 cancel 事件时会导致 crash,使用 touchend 时真机更容易复现 #307
2. 增加 touch event 测试用例
@answershuto
Copy link
Member

是因为这个事件抛出去导致的吗?
https://github.com/openkraken/kraken/blob/main/kraken/lib/src/gesture/click.dart#L70

@airingursb
Copy link
Member Author

是的,没错,走到 cancel 事件的时候就会 crash

@answershuto answershuto self-requested a review May 14, 2021 03:47
Copy link
Member

@answershuto answershuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@answershuto answershuto merged commit d8079a4 into openkraken:main May 14, 2021
@andycall
Copy link
Member

andycall commented May 14, 2021

Fixed #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants