fix: fix bridge with getStringProperty on InputElement. #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycall
requested review from
wssgcg1213 and
answershuto
and removed request for
wssgcg1213
temper357
approved these changes
Jun 2, 2021
wssgcg1213
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
读取 Element 属性之前，需要先 flushUICommand 创建 Element。
这是这个性能优化引发的一个 Bug，https://github.com/openkraken/kraken/pulls?q=is%3Apr+is%3Aclosed
经检查，其他类似的情况都添加了 flushUICommand 的调用