fix: fix ios app store #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssgcg1213
previously approved these changes
Nov 4, 2021
wssgcg1213
reviewed
Nov 4, 2021
wssgcg1213
reviewed
Nov 4, 2021
|
|
|
MinimumOSVersion 字段还是缺失的 |
andycall
force-pushed
the
fix/ios-bridge-build
branch
from
7d0384e
to
79fb7c4
Compare
wssgcg1213
reviewed
Nov 5, 2021
| @@ -454,6 +475,9 @@ task(`build-ios-kraken-lib`, (done) => { | |||
| const armDynamicSDKPath = path.join(paths.bridge, `build/ios/lib/arm/${target}.framework`); | |||
| const x64DynamicSDKPath = path.join(paths.bridge, `build/ios/lib/x86_64/${target}.framework`); | |||
|
|
|||
| patchiOSFrameworkPList(x64DynamicSDKPath); | |||
There was a problem hiding this comment.
simulator 的没关系, 这个不会提交到 AppStore 的
wssgcg1213
approved these changes
Nov 8, 2021
answershuto
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #846