fix: br element size #867
Merged
fix: br element size #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temper357
requested review from
yuanyan,
wssgcg1213,
andycall and
answershuto
yuanyan
reviewed
Nov 23, 2021
yuanyan
reviewed
Nov 23, 2021
yuanyan
reviewed
Nov 23, 2021
yuanyan
reviewed
Nov 23, 2021
wssgcg1213
reviewed
Nov 25, 2021
wssgcg1213
reviewed
Nov 25, 2021
wssgcg1213
reviewed
Nov 25, 2021
wssgcg1213
reviewed
Nov 25, 2021
…nt-size # Conflicts: # kraken/lib/rendering.dart
…nt-size # Conflicts: # kraken/lib/src/dom/elements/semantics_text.dart
|
浏览器对 BR element 设置 style 是生效的，也能正常读出，只是渲染不生效，因此不能使用在 bridge 侧阻断 style 指令的方式实现。 |
yuanyan
approved these changes
Dec 13, 2021
wssgcg1213
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #737
修复 BR element 高度不生效，BR element 是一个特殊的 element，设置任何 style 都不生效，同时高度只由 parent 的 line-height 决定，由于 HTML 规范中定义 BR element 实际上会被转化成一个换行符 https://www.w3.org/TR/CSS1/#br-elements ，因此 Kraken 通过渲染一个空字符串来获取换行的真实高度。