Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix add_target_repo when signing role is the top-level targets role #431

Merged
merged 5 commits into from
May 27, 2024

Conversation

renatav
Copy link
Collaborator

@renatav renatav commented May 23, 2024

Description (e.g. "Related to ...", etc.)

Role paths should not be added if the signing role is the top-level targets role

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

Role paths should not be added if the signing role is the top-level targets role
@renatav renatav requested a review from n-dusan May 23, 2024 21:37
@renatav renatav self-assigned this May 23, 2024
@renatav renatav merged commit a50a4c5 into master May 27, 2024
25 checks passed
@renatav renatav deleted the renatav/fix-add-target branch May 27, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants