Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite fixes #218

Merged
merged 6 commits into from
Feb 28, 2012
Merged

Testsuite fixes #218

merged 6 commits into from
Feb 28, 2012

Conversation

marcjansen
Copy link
Member

In Chrome 17.x two tests fail due to mixed precision when compairing numerical values.
In Firefox 10.0.1 additionally an OverviewMap test and a Format.XML test fails.

@elemoine
Copy link
Member

@marcjansen you're the kind, I'll take a look.

@fredj
Copy link
Member

fredj commented Feb 15, 2012

see also #161 and #162

@marcjansen
Copy link
Member Author

As of 67ea250 there are still 6 tests failing in Firefox 10.0.1 on Linux:

  • Layer/GeoRSS.html: fail 3 ok 8 (detailed: fail 1 ok 23)
    • test_Layer_GeoRSS_AtomParsing planned 6 assertions but got 3; fail 1 ok 2
    • test_Layer_GeoRSS_popups planned 4 assertions but got 0; fail 0 ok 0
    • test_Layer_GeoRSS_resizedPopups planned 4 assertions but got 0; fail 0 ok 0
  • Layer/Text.html: fail 2 ok 6 (detailed: fail 0 ok 31)
    • test_Layer_Text_overflow planned 4 assertions but got 0; fail 0 ok 0
    • test_Layer_Text_events_nopopups planned 4 assertions but got 0; fail 0 ok 0
  • Map.html: fail 1 ok 55 (detailed: fail 1 ok 313)
    • test_panTo fail 1 ok 5
  • Tween.html: fail 1 ok 2 (detailed: fail 3 ok 7)
    • test_Tween_start fail 3 ok 2
  • deprecated/Layer/MapServer.html: fail 1 ok 0 (detailed: fail 2 ok 3)
    • test_Layer_MapServer_Reproject fail 2 ok 3
  • deprecated/Layer/WMS.html: fail 1 ok 0 (detailed: fail 2 ok 3)
    • test_Layer_WMS_Reproject fail 2 ok 3

Chrome 17 runs the complete suite without errors.

@elemoine elemoine mentioned this pull request Feb 28, 2012
@elemoine
Copy link
Member

I can confirm that the Control.OverwiewMap, Format.WKT and Strategy.BBOX tests now pass in FF 10, Chrome, and IE 8. Thanks a lot for fixing that @marcjansen. Please merge.

FYI, we have more failing tests, see #249. I'd happily use some help to make all tests pass again.

marcjansen added a commit that referenced this pull request Feb 28, 2012
@marcjansen marcjansen merged commit 631f6b5 into openlayers:master Feb 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants