Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ol3pickr - UI for a component-picker for a customized ol3 JS lib #42

Closed
wants to merge 6 commits into from
Closed

Conversation

eshon
Copy link

@eshon eshon commented Mar 18, 2015

Live example:

http://eshon.github.io/openlayers.github.io/ol3pickr/ol3pickr.html

Questions:

  1. Has description been added to the symbols in a new json output?
  2. On expanding ol.tilegrid:

TileGrid appears twice, once as its own class, and second time as the root of a set of functions. Is this correct or should it only appear once (can you include the class without all of its methods?)?

  1. What format of json should be submitted by the form to the server?
  2. Should there be categories for Core, Touch, etc.?
  3. Should I make a PR of the live page on the gh-pages branch as well?

@ahocevar
Copy link
Member

Thanks @eshon for working on this. Here are answers to your questions:

Has description been added to the symbols in a new json output?

Yes. Here is a build/info.json file from current master.

TileGrid appears twice, once as its own class, and second time as the root of a set of functions. Is this correct or should it only appear once (can you include the class without all of its methods?)?

There seems to be a problem. It should only appear once. You can see the same problem with all classes from the ol.tilegrid namespace (like XYZ, WMTS).

What format of json should be submitted by the form to the server?

We have to flesh that out. It may also be the case that we have to move this pull request to a different repository. I've added this as sprint task for Schladming. I'll keep you posted.

Should there be categories for Core, Touch, etc.?

I don't think this will be necessary. But sorting the categories alphabetically might help.

Should I make a PR of the live page on the gh-pages branch as well?

Since we don't know yet where and how this is going to be hosted, it is perfectly fine to have it available the way it is for now.

@ohmu808
Copy link

ohmu808 commented Mar 30, 2015

Classes appearing twice should be fixed but there are a few bugs to address e.g. ol.tilegrid.WMTS.createFromCapabilitiesMatrixSet is not appearing in the right subgroup.

@ahocevar your build/info.json should contain a hash instead of a dot:

ol.tilegrid.WMTS#createFromCapabilitiesMatrixSet
not ol.tilegrid.WMTS.createFromCapabilitiesMatrixSet

@jipexu
Copy link

jipexu commented Jul 24, 2022

is this request still valid (7yr) ? If not it could be closed?

@tschaub
Copy link
Member

tschaub commented Aug 2, 2022

I think it is probably safe to close.

@tschaub tschaub closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants