Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apidoc cleanup navigation html #10625

Merged
merged 2 commits into from
Feb 13, 2020

Conversation

MoonE
Copy link
Contributor

@MoonE MoonE commented Feb 9, 2020

Generates smaller apidoc .html pages and fixes invalid structure of the member lists where the subtitle span was a direct child of the ul which is invalid html.
File sizes are reduced by >33% without obfuscating the structure.

- Add a function that is used to generate all four types of member lists.
- Only use one line per list item.
- Don't generate empty `class=""` attributes when item is stable.
- Remove closing `</li>` tag, as is allowed by the html 5 standard.

Overall this reduces the filesize for the generated html pages by ~33%.
Only `<li>` can be a direct descendant of `<ul>` tags.
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement. Thanks!

@ahocevar ahocevar merged commit 8b6d5eb into openlayers:master Feb 13, 2020
@MoonE MoonE deleted the apidoc-cleanup-navigation branch February 16, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants