Wait for icons to be loaded before firing rendercomplete event #13626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the examples and docs from this branch here: https://deploy-preview-13626--ol-site.netlify.app/. |
|
Yes, I believe the |
|
Excellent, thanks! |
MoonE
force-pushed
the
rendercomplete-wait-for-icons
branch
from
33233dd
to
2d82233
Compare
MoonE
force-pushed
the
rendercomplete-wait-for-icons
branch
from
2d82233
to
e8925a9
Compare
MoonE
commented
May 24, 2022
| @@ -255,7 +250,6 @@ class CanvasVectorTileLayerRenderer extends CanvasTileLayerRenderer { | |||
| const bufferedExtent = equals(sourceTileExtent, sharedExtent) | |||
| ? null | |||
| : builderExtent; | |||
| builderState.dirty = false; | |||
There was a problem hiding this comment.
Looks like this did only take the last source tile's dirty state into account.
| @@ -289,7 +283,6 @@ class CanvasVectorTileLayerRenderer extends CanvasTileLayerRenderer { | |||
| builderGroup, | |||
| declutterBuilderGroup | |||
| ); | |||
| this.dirty_ = this.dirty_ || dirty; | |||
There was a problem hiding this comment.
this.dirty_ was never reset to false , though it was also unused.
| for (let i = tiles.length - 1; i >= 0; --i) { | ||
| const tile = /** @type {import("../../VectorRenderTile.js").default} */ ( | ||
| tiles[i] | ||
| ); | ||
| ready = ready && !tile.getReplayState(layer).dirty; |
There was a problem hiding this comment.
ready is true when the currently drawn tiles have no loading icons. Tile state is tracked separately.
ahocevar
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rendercomplete event should wait for icons to load before it is being fired.
As there is already similar behavior for the webgl renderers with the
readyproperty, this uses the same property.This also fixes an error when an icon is loaded after the renderer has been disposed.