Fix PIP refresh #13
Merged
Fix PIP refresh #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a side effect of certain entries showing up multiple times in the network tree however.
…re entries of the same protocls accumulating below.
|
See log. At 10:22:46.842, there are now two PIP requests addressed to the same node. My guess is that the second one is from the Firmware Upgrade which also requested a protocol identification in the past. Other than that, it seems to be ok. Thanks, |
|
The extra PIP request is sent out by the firmware updater in order to ensure that there is a freshest PIP information available. These are different modules in the process, so collaborating between them would take more complicated APIs thus is not really desirable to fix. I can see that your node was smart enough to collapse these into one PIP reply, that's pretty neat. That reply was routed to both requestors in the memory of the JMRI process. |
pabender
pushed a commit
to pabender/OpenLCB_Java
that referenced
this pull request
Feb 28, 2017
Fix PIP refresh upon initialization complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also updates the list of PIP entries from the 2016 standards.