Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new author type "Altered by" #39

Closed
smehrbrodt opened this issue Jun 1, 2017 · 1 comment
Closed

Add new author type "Altered by" #39

smehrbrodt opened this issue Jun 1, 2017 · 1 comment
Assignees
Milestone

Comments

@smehrbrodt
Copy link
Contributor

Requested here: https://bugs.launchpad.net/openlp/+bug/1546530

@gyuris gyuris added this to the 0.9 milestone Jun 10, 2020
@gyuris
Copy link
Member

gyuris commented Aug 9, 2020

OK, lets standardise this author type. "Altered by" is a good label for OpenLP, but it doesn't fit other types. Other author types are currently:

  • words
  • music
  • translation (+language)

They answers the question: What this author produced? So I suggest: alteration, variant, revision...

We have currently a <variant> tag in metadata, see in documentation. It suggest variant. It would be clear that if a song has a variant that we can assign an author with variant type:

<variant>Newsboys</variant>
<authors>
  <author type="words">XY</author>
  <author type="music">XY</author>
  <author type="variant">Michael Tait</author>
</authors>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants