Add function for getting effective dose coefficients from ICRP-116 #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
requested changes
May 25, 2020
There was a problem hiding this comment.
Pretty simple and clean addition of the ICRP dose coefficients. As you said, these should be easy to hand off to an EnergyFunctionFilter Thanks @paulromano!
A line comments and a couple questions.
pshriwise
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple addition here based on a user request -- this PR adds a
openmc.data.dose_coefficientsfunction which provides effective dose coefficients from ICRP-116. The data tables were pulled directly from supplemental material distributed with the article itself. The new functionality reads in the data from those tables and provides an interface to access them. To actually use these in a tally, one would have to supply the returned energy/dose values to anEnergyFunctionFilter.