Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unused which function in CI scripts #3095

Merged
merged 1 commit into from
Jul 24, 2024
Merged

removed unused which function in CI scripts #3095

merged 1 commit into from
Jul 24, 2024

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Jul 23, 2024 •
edited
Loading

I noticed we have an unused function here in the CI called which.

We make use of shutil.which elsewhere in the code but I think this function in the CI script is unused so I guess we can remove it.

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)

paulromano
paulromano approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulromano paulromano merged commit e5cc925 into openmc-dev:develop Jul 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulromano paulromano paulromano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shimwell @paulromano