Return all validation errors from configuration #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagikazarmark
added
the
kind/refactor
sagikazarmark
commented
Sep 23, 2024
sagikazarmark
force-pushed
the
validation
branch
from
96bffe6
to
d45556f
Compare
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
sagikazarmark
force-pushed
the
validation
branch
from
d45556f
to
923f358
Compare
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
sagikazarmark
force-pushed
the
validation
branch
from
3f6ddd9
to
ede9550
Compare
GAlexIHU
approved these changes
Oct 2, 2024
| if err := c.ConsumerConfiguration.Validate(); err != nil { | ||
| return err | ||
| errs = append(errs, errorsx.WithPrefix(err, "consumer")) |
There was a problem hiding this comment.
Nit: I think it would be better if the prefixes used the full name of the configuration object, it would make things 100% unambiguous (e.g. consumer => ConsumerConfiguration)
Wdyt?
There was a problem hiding this comment.
Hm...maybe
Right now it follows the name as it appears in the config file which probably makes it easier to debug a problem.
Ultimately, this should be a "path" to the configuration (whether it's file or not), but people rarely look at the code to figure out configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Instead of returning on error at a time, config now returns all validation errors.
Notes for reviewer