Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to /clients #78

Closed
muddlebee opened this issue Jun 28, 2018 · 9 comments
Closed

Add pagination to /clients #78

muddlebee opened this issue Jun 28, 2018 · 9 comments
Labels
c4gw Code for Good Week design User interface good first issue Good for newcomers gsoc 2018 Google Summer of Code 2018

Comments

@muddlebee
Copy link
Contributor

muddlebee commented Jun 28, 2018

/clients

  • Angular material pagination
@muddlebee muddlebee added good first issue Good for newcomers design User interface c4gw Code for Good Week labels Jun 28, 2018
@mdew192837
Copy link

I think I can take my hand at this.

Is there anything I should be cautious of @anweshknayak ?

@mdew192837
Copy link

Also, according to https://openmf.github.io/web-app/clients, it looks like pagination already exists?

@muddlebee
Copy link
Contributor Author

@mdew192837 you have to use https://demo.openmf.org/api-docs/apiLive.htm#clients_list the pagination feature from the API given in link and plug into material angular pagination feature which we are using.

Also you can take a look how we are fetching API calls https://github.com/openMF/web-app/blob/master/src/app/clients/clients.service.ts

@muddlebee
Copy link
Contributor Author

muddlebee commented Jun 29, 2018

Currently only material angular pagination layout works which is the UI part. It is not plugged into the API yet. For testing purpose you can set to 4 pages per list as the clients list is not populated.

@mdew192837
Copy link

@anweshknayak I don't think the link to the API docs is working. Is there an alternative?

@muddlebee
Copy link
Contributor Author

muddlebee commented Jun 30, 2018 via email

@mdew192837
Copy link

I'm a bit confused in regards to steps I need to implement. For example, I think I need page number, length, and a way to dynamically get the right users. I think i do that by using the offset property, but I can't seem to get pagination to work. @anweshknayak

@muddlebee
Copy link
Contributor Author

@mdew192837 take a look at this for inspiration https://blog.angular-university.io/angular-material-data-table/

@muddlebee
Copy link
Contributor Author

#115

@abhaychawla abhaychawla added the gsoc 2018 Google Summer of Code 2018 label Mar 23, 2019
@abhaychawla abhaychawla added this to the GSoC 2018: Phase 2 milestone Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c4gw Code for Good Week design User interface good first issue Good for newcomers gsoc 2018 Google Summer of Code 2018
Projects
None yet
Development

No branches or pull requests

3 participants