Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iviewer multiviewers on double-click #81

Closed
will-moore opened this issue Dec 20, 2017 · 2 comments
Closed

iviewer multiviewers on double-click #81

will-moore opened this issue Dec 20, 2017 · 2 comments

Comments

@will-moore
Copy link
Member

This continues the design from #79
focusing only on the opening of viewers with double-click.

As discussed with @pwalczysko (see his last comment #79 (comment)) we can simplify the desired behaviour (no 'pinning', 'temporary windows' etc):

  • No single vv multi-viewer mode.
  • When a single viewer is open, behaviour is same as current behaviour.
  • Single-clicking on a thumbnail opens the image in the currently-active viewer (does nothing if current viewer is already showing that image).
  • Double-click on a thumbnail will open the image in a NEW viewer panel.
  • When closing viewers, when only a single one is open it reverts to filling the space (as current behaviour).

cc @waxenegger @jburel

@waxenegger
Copy link
Member

waxenegger commented Feb 1, 2018

@will-moore @jburel distinction between single and double clicks in terms of event handling is an undetermined nuisance. In essence a double click is very likely to cause a single click event first, after that a double click event is fired. According to some sources out there some browsers could even do it the other way round. But even if we assume it's the former which is the behavior I get one needs a timer solution to handle that. Hacky at best. Here is what the jquery doc has to say: https://api.jquery.com/dblclick/ (but it's really something that is problematic based on generic event handling, not jquery, I wouldn't even be using jquery in that case)

@jburel
Copy link
Member

jburel commented Feb 1, 2018

Another option could be to drag a thumbnail from left panel to centre panel
to open in multiview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants