Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No descriptors in JAR #41

Closed
reckart opened this issue Apr 9, 2018 · 0 comments
Closed

No descriptors in JAR #41

reckart opened this issue Apr 9, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@reckart
Copy link
Member

reckart commented Apr 9, 2018

Unfortunately, the change introduced with #36 did not work as desired. The reason is twofold:

  • that resources are being processed in the process-resources but the OMTD-SHARE plugin runs in the process-classes classes phase
  • the plugin doesn't actually add a new resource folder, but a new source folder and Maven only copies classes from source folders to the target folders... and even that happens again in an earlier phase

So while it is still a reasonable idea to keep the generated resources in a separate folder (and maybe even to add that folder as a source or resource folder so IDEs treat them as source folders), we unfortunately have to handle the copying of the data to the target folder ourselves.

@reckart reckart added the bug label Apr 9, 2018
@reckart reckart self-assigned this Apr 9, 2018
@reckart reckart closed this as completed Apr 9, 2018
reckart added a commit that referenced this issue Apr 9, 2018
- Fix copying of descriptors to output folder so they actually end up in the JARs.
@reckart reckart added this to the 3.0.2.5 milestone Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant