Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'Atom' object has no attribute 'element' #233

Closed
arjunNUFC opened this issue Sep 9, 2022 · 9 comments
Closed

AttributeError: 'Atom' object has no attribute 'element' #233

arjunNUFC opened this issue Sep 9, 2022 · 9 comments

Comments

@arjunNUFC
Copy link

Maybe this is related to issue #225, but I am getting an error using
openmmforcefields 0.11.1 pyhd8ed1ab_0 conda-forge
along with the new OpenFF toolkit 0.11.0
openff-toolkit 0.11.0 pyhd8ed1ab_1 conda-forge

I am using SMIRNOFFTemplateGenerator with openff-2.0.0 as the ligand force field.
And i run into this error:

..."/python3.10/site-packages/openmmforcefields/generators/template_generators.py", line 966, in convert_system_to_ffxml
    element=particle.element.symbol, mass=as_attrib(particle.element.mass))
AttributeError: 'Atom' object has no attribute 'element'

Is the current version of openmmforcefields not compatible with the new toolkit ?

Thanks all

@mattwthompson
Copy link
Collaborator

Is the current version of openmmforcefields not compatible with the new toolkit ?

Correct, we're still working on getting the fix rolled out, sorry.

@arjunNUFC
Copy link
Author

Ok thanks Matt

@mattwthompson
Copy link
Collaborator

After #227 this is now merged into the main branch. We should wait to close this until a release is made, though.

@mikemhenry
Copy link
Collaborator

I'm sorry I lied in the release notes 🙈
https://github.com/openmm/openmmforcefields/releases/tag/0.11.1

I will get a new release out ASAP.

@mikemhenry
Copy link
Collaborator

Once we get #237 resolved, we should be ready for a release.

@mikemhenry
Copy link
Collaborator

mikemhenry commented Sep 20, 2022

@arjunNUFC This is now fixed on main, we will get the conda-forge release out soon, but if you install it like this python -m pip install git+https://github.com/openmm/openmmforcefields.git then things should work with the new toolkit!

I will keep this issue open until we get the conda-forge release out.

@mattwthompson
Copy link
Collaborator

This should be resolved now, just make sure you're grabbing version 0.11.2 or newer, i.e.

$ conda install "openmmforcefields >=0.11.2" -c conda-forge

or similar syntax if installing from an environment file.

Please let us know if you run into more issues!

@arjunNUFC
Copy link
Author

arjunNUFC commented Sep 26, 2022 via email

@mikemhenry
Copy link
Collaborator

Closed now that we have 0.11.2 released 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants