Revamp PDBFixer testing #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use GitHub Actions to run a suite of tests * Switch from nose to pytest (nose has not been supported in years) * Download a PDB file and track it instead of fetching it during CI (RCSB has blocked testing frameworks in the past).
|
I hadn't seen #222 This actually adds some testing, or it should at least. |
|
Also fixes #224. We should still likely convert to using the MolSSI cookiecutter at some point down the road! |
|
Tests now pass: https://github.com/swails/pdbfixer/runs/3468227261?check_suite_focus=true I'll clean up the branch trigger names and this should be good to merge. Then I'll proceed to the cleanups I need. |
|
@peastman this is ready to merge, and results in passed tests on Python 3.7 - Python 3.9 |
|
That looks excellent. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(RCSB has blocked testing frameworks in the past).