Configure data layer #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HectorNarvaez
requested review from
wilsoncastiblanco,
jdiegoh3,
Anwera64,
hans-hamel and
bardur-encora
Anwera64
reviewed
May 15, 2023
...ive-nongms/src/main/java/com/omh/android/storage/api/drive/nongms/data/GoogleRetrofitImpl.kt
Outdated
Show resolved
Hide resolved
...ive-nongms/src/main/java/com/omh/android/storage/api/drive/nongms/data/GoogleRetrofitImpl.kt
Outdated
Show resolved
Hide resolved
...ongms/src/main/java/com/omh/android/storage/api/drive/nongms/data/GoogleStorageApiService.kt
Outdated
Show resolved
Hide resolved
...gms/src/main/java/com/omh/android/storage/api/drive/nongms/data/source/mapper/DataMappers.kt
Show resolved
Hide resolved
...gms/src/main/java/com/omh/android/storage/api/drive/nongms/data/source/mapper/DataMappers.kt
Outdated
Show resolved
Hide resolved
storage-api/src/main/java/com/omh/android/storage/api/data/mapper/FileTypeMapper.kt
Outdated
Show resolved
Hide resolved
storage-api/src/main/java/com/omh/android/storage/api/data/mapper/FileTypeMapper.kt
Outdated
Show resolved
Hide resolved
Merged
HectorNarvaez
force-pushed
the
state/configureRetrofit
branch
from
bf34b52
to
eebbefd
Compare
HectorNarvaez
force-pushed
the
state/configureRetrofit
branch
from
eebbefd
to
0cd49a0
Compare
HectorNarvaez
removed
Don't merge
Anwera64
approved these changes
May 16, 2023
...ive-nongms/src/main/java/com/omh/android/storage/api/drive/nongms/data/GoogleRetrofitImpl.kt
Show resolved
Hide resolved
HectorNarvaez
added a commit
that referenced
this pull request
May 16, 2023
* Setup retrofit and refactor on data layer due to architecture changes * Sample app module is broken. Removed temporally * Solve comments * Solve comments --------- Co-authored-by: Hector Narvaez <hector.narvaez@CSABOGMB042.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR is being configured the data layer of non-omh module and include changes in some models due to architecture changes.
As files and folders have exactly the same information, the intention with this is remove the tree current repositories (FileRepository, FolderRepository and FileFolderRepository) and have only one generic file that can be a document or a forlder.
This PR depends on #7 and can see easy diff clicking here