Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/vehicles in MDS 2.0 #857

Closed
sven4all opened this issue Apr 28, 2023 · 9 comments
Closed

/vehicles in MDS 2.0 #857

sven4all opened this issue Apr 28, 2023 · 9 comments
Labels
Agency Specific to the Agency API Provider Specific to the Provider API
Milestone

Comments

@sven4all
Copy link

Is your feature request related to a problem? Please describe.

In MDS 2.0 a lot of information is removed from vehicle object in the /provider/agency endpoint, but at the same time the documenatation of the /provider/agency endpoint doesn't seems te be upgraded yet https://github.com/openmobilityfoundation/mobility-data-specification/blob/release-2.0.0/provider/README.md#vehicles, a comparison is made with /free_bike_status of GBFS for example, while the goal of this endpoint seems to be completely changed with the 2.0 version.

Describe the solution you'd like

We develop an open-source dashboard for municipalities within the Netherlands and relly heavily on this /vehicles endpoint https://dashboarddeelmobiliteit.nl/. We therefor think we should reconsider removing the status and location information from this endpoint. Another option would be to have a get all on the vehicle_status endpoint. We think that as a dashboard you always want to retreive all the vehicle_statuses at once, and therefor don't see any benefit at all in the pagination that is suggested. If there will be pagination we want to have a minimal number of vehicles per page of 10000 to prevent performance problems if you need to fetch 30000 vehicles for example with a page size of 20 (we have seen this in the past).

Is this a breaking change

This change is currently not breaking, because 2.0 is not release yet.

Impacted Spec

  • provider
@schnuerle
Copy link
Member

schnuerle commented May 2, 2023

Hi @sven4all could you describe this in a different way? I'm not sure I follow what you are asking for. Do you want less fields like no status and location from vehicles? Or do you want to get all the data at once and so pagination is a problem? Or are these both separate concerns for you?

Which documentation for Provider and Agency endpoints is not updated yet?

Are you pulling authenticated data from city data feeds to generate your public dashboard using a subset of this? If so why not use the public data in GBFS feeds for this - are there some fields you are showing that GBFS is not?

@schnuerle schnuerle added Provider Specific to the Provider API Agency Specific to the Agency API labels May 2, 2023
@schnuerle
Copy link
Member

Do you think your issues here are related to #862?

@sven4all
Copy link
Author

sven4all commented May 4, 2023 via email

@jiffyclub
Copy link
Contributor

I agree about the pagination, it can add a lot of time to getting data when pages are small, especially if each individual request is slow.

@schnuerle
Copy link
Member

@sven4all Take a look at the discussion on #862. I think it clarifies that the real time information you are looking for is still in 2.0, just in a different way.

It's too late for changes for 2.0, but we can continue to discuss here for the future.

@sven4all
Copy link
Author

sven4all commented May 6, 2023 via email

@sven4all
Copy link
Author

@jiffyclub @schnuerle how can we proceed with this discussion?

@jiffyclub
Copy link
Contributor

#882 clarifies the documentation of the vehicles endpoints in the provider spec and is slated for MDS 2.0.1.

@schnuerle schnuerle added this to the 2.0.1 milestone Dec 11, 2023
@schnuerle
Copy link
Member

Resolved with #882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agency Specific to the Agency API Provider Specific to the Provider API
Projects
None yet
Development

No branches or pull requests

3 participants