CMakeLists: fixed default build type, added option for static build #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements in CMakeLists
Issue: When CMAKE_BUILD_TYPE was not provided by the user (the variable was empty), cmake defaulted to a debug build. As a result, the default compilation run without any options (and that's what most users will do) yields a binary with lower performance.
Solution: The default value is set depending on ENABLE_COVERAGE which correctly defaults to OFF. Therefore, in no options are set by user, the build type is set to "Release". Additionally, if both options are set, conflict between CMAKE_BUILD_TYPE=Release and ENABLE_COVERAGE=ON is checked and yields an error.
Additional feature: I've added a new option STATIC_BUILD for building a static binaries. The default is OFF, and the script behaves the same as before. The static compilation works well with gfortran/OpenBlas but fails with Intel/MKL.
Status