Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install OMP shared library AND symbolic link #72

Closed
wants to merge 6 commits into from

Conversation

godotalgorithm
Copy link
Collaborator

Sigh, yet another correction to fix the incorrect fix in #46. Previously, I had accidentally installed the symbolic link to the shared library, but not the shared library itself. I replaced that with installing the shared library, but not its symbolic link, because I thought that the executable contained a path to the underlying shared library. Apparently, I'm wrong and both the shared library and its symbolic link need to be installed.

Status

  • Ready for merge

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #72 (9901ac6) into main (f10d4d9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   68.23%   68.23%           
=======================================
  Files         330      330           
  Lines       71706    71706           
=======================================
  Hits        48932    48932           
  Misses      22774    22774           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f10d4d9...9901ac6. Read the comment docs.

@godotalgorithm
Copy link
Collaborator Author

On closer examination, I have misunderstood the problem. It is correct that the executable is pointing to the underlying shared library and not any symbolic links to it. However, the Linux executable is now pointing to two separate OpenMP libraries, libomp.so.5 and libiomp5.so. In some instances, libiomp5.so is a symbolic link to libomp.so.5, but in other instances it is a shared library unto itself. This appears to be confusing the linking process on Linux somehow, and it is very likely to be related to my recent reactivation of the THREADS keyword. This PR is thus irrelevant and misguided.

@godotalgorithm godotalgorithm deleted the installer-hotfix branch July 6, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants