Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCLOMRS-294: Clean up application dependencies #210

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

abulojoshua1
Copy link
Contributor

JIRA TICKET NAME:

Clean up application dependencies

Summary:

Currently, in the application dependencies file(package.json), app development dependencies are mixed with app dependencies and there are some unused dependencies listed there. This should be worked on and do and clean up.

@abulojoshua1 abulojoshua1 force-pushed the OCLOMRS-294 branch 2 times, most recently from e882d70 to 5b6e194 Compare November 8, 2018 06:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1223

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.859%

Totals Coverage Status
Change from base Build 1219: 0.0%
Covered Lines: 1362
Relevant Lines: 1453

💛 - Coveralls

Copy link
Contributor

@muhozi muhozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AGMETEOR AGMETEOR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Duncanian Duncanian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Daramola98 Daramola98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkayiwa dkayiwa merged commit 0dbd186 into openmrs:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants