Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device_id fixed, hardcoded ip/port fixed, non-strict-ssl added #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

device_id fixed, hardcoded ip/port fixed, non-strict-ssl added #205

wants to merge 1 commit into from

Conversation

n1654
Copy link
Contributor

@n1654 n1654 commented Aug 23, 2021

minor issues fixed,
"non-strict-ssl": true
flag added

abr-ubiqube
abr-ubiqube reviewed Nov 3, 2021
View reviewed changes
Copy link
Contributor

@abr-ubiqube abr-ubiqube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @n1654
that's an old PR, is it still to be merged?

@abr-ubiqube
Copy link
Contributor

There seems to be some TelekomMalasia things here, so I guess we don't merge to master

@n1654
Copy link
Contributor Author

n1654 commented Nov 3, 2021

Hello @abr-ubiqube,
yes, this is a TM POC specific WF
I don't think we should keep it in master, I'd better copy it in some POC related repo, but I'm not sure if such exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abr-ubiqube abr-ubiqube abr-ubiqube left review comments

@sle38 sle38 Awaiting requested review from sle38

@UBiqube-ydu UBiqube-ydu Awaiting requested review from UBiqube-ydu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n1654 @abr-ubiqube