Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Portuguese Brazilian translation #21

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

gHenriqueCarlos
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

@LESS14 LESS14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to name it "ptbr" since, in this grammar, there's no distinction between European Portuguese and Brazilian Portuguese. For better understanding, rename it as "pt".

@pkfln
Copy link
Member

pkfln commented Nov 12, 2023

There's no need to name it "ptbr" since, in this grammar, there's no distinction between European Portuguese and Brazilian Portuguese. For better understanding, rename it as "pt".

There definitely are differences between European and Brazilian Portuguese. The correct locale is pt-BR for this one.

src/locales/translations/ptbr.ts Outdated Show resolved Hide resolved
src/locales/translations/ptbr.ts Outdated Show resolved Hide resolved
src/locales/translations/ptbr.ts Outdated Show resolved Hide resolved
src/locales/translations/ptbr.ts Outdated Show resolved Hide resolved
src/locales/translations/ptbr.ts Outdated Show resolved Hide resolved
@LESS14
Copy link

LESS14 commented Nov 12, 2023

There's no need to name it "ptbr" since, in this grammar, there's no distinction between European Portuguese and Brazilian Portuguese. For better understanding, rename it as "pt".

There definitely are differences between European and Brazilian Portuguese. The correct locale is pt-BR for this one.

Not in this case, since this grammar can be easily understood by both accents.

@pkfln
Copy link
Member

pkfln commented Nov 12, 2023

I just skimmed through it and as someone that learned European Portuguese, I wouldn't have known what they meant by "Apelido" in this case. I've only seen username/nickname/alcunha/usario being used.

@gHenriqueCarlos
Copy link
Contributor Author

I just skimmed through it and as someone that learned European Portuguese, I wouldn't have known what they meant by "Apelido" in this case. I've only seen username/nickname/alcunha/usario being used.

We can replace 'Apelido' with 'Nome de Usuário' or just 'Usuário.' I believe it will work well for both. What do you think?

@LESS14
Copy link

LESS14 commented Nov 12, 2023

We can replace 'Apelido' with 'Nome de Usuário' or just 'Usuário.' I believe it will work well for both. What do you think?

It would be better, in my opinion, since it would make it easier for both European Portuguese and Brazilian Portuguese to understand.

Copy link
Contributor

@Southclaws Southclaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito bom, obrigado!

@Southclaws Southclaws merged commit ea2a4e5 into openmultiplayer:master Nov 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants