-
Notifications
You must be signed in to change notification settings - Fork 91
fix: exclude musl
binaries from function bundle when building on Netlify with pnpm
#3145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good to me. Just before the merge, it would be good to update PR title to indicate this applies only to buildbot so release notes are not confusing for CLI users expecting improvements with release of this change
musl
binaries from function bundle when building on Netlify with pnpm
Description
When deploying on Netlify and building with
pnpm
, ensure we aren't including packages for bothmusl
andgnu
libc variants. Without this change, function bundles take up effectively twice as much space.Relevant links (GitHub issues, etc.) or a picture of cute animal
See in-line comments for relevant Github issue links