Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapted header of TOC to specs #116

Merged
merged 1 commit into from
Oct 27, 2022
Merged

adapted header of TOC to specs #116

merged 1 commit into from
Oct 27, 2022

Conversation

voisardf
Copy link
Collaborator

@voisardf voisardf commented Jul 5, 2022

Fixed german titles as defined on page 14 of the specs regarding the PDF extract

@voisardf voisardf added bug Something isn't working usergroup work labels Jul 5, 2022
@voisardf voisardf self-assigned this Jul 5, 2022
@voisardf voisardf mentioned this pull request Jul 5, 2022
Closed
marionb
marionb approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@marionb marionb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff they get ever longer :-D
Thanks!

@voisardf
Copy link
Collaborator Author

voisardf commented Jul 5, 2022

@marionb yep. I asked V+D which ones to take (#115) indicating that the shorter, existing version is preferred

@voisardf voisardf changed the title adapted header of TOC to specs [WIP - waiting for answer of V+D] adapted header of TOC to specs Jul 5, 2022
@voisardf voisardf closed this Oct 5, 2022
@voisardf voisardf reopened this Oct 27, 2022
@voisardf
Copy link
Collaborator Author

@michmuel Are this the changes you need? Something missing?

@voisardf voisardf changed the title [WIP - waiting for answer of V+D] adapted header of TOC to specs adapted header of TOC to specs Oct 27, 2022
@voisardf voisardf merged commit c8d1ba6 into master Oct 27, 2022
@voisardf voisardf deleted the 115-fix_german_toc_titles branch October 27, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marionb marionb marionb approved these changes

@michmuel michmuel michmuel approved these changes

@vvmruder vvmruder Awaiting requested review from vvmruder

@jwkaltz jwkaltz Awaiting requested review from jwkaltz

Assignees

@voisardf voisardf

Labels
bug Something isn't working usergroup work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voisardf @marionb @michmuel