Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up old Windows binaries on open instead of cleaning up on shutdown to close #5 #8

Closed
wants to merge 2 commits into from

Conversation

phrack
Copy link

@phrack phrack commented Aug 18, 2016

Sorry for the total change to the file, the format kept breaking on me so I just ran a formatter on the entire file.

My changes are from lines 112 - 129 and 399 - 407.

@vonnieda
Copy link
Member

This looks great. I have some small requests:

  1. Can you try to resubmit without the reformatting? If this is a pain I can do it for you. As of right now it's too hard to tell what changed.
  2. Can you change the temp directory prefix to openpnp_opencv or org.openpnp.opencv or something else more specific? I just want to make sure we don't accidentally delete something that isn't ours.

Thanks,
Jason

@phrack
Copy link
Author

phrack commented Aug 22, 2016

Hmm, has the old formatting now except for my additions but it doesn't fix the diff since I commited over it already in my fork. Let me close this one and try from a fresh fork.

@phrack phrack closed this Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants