Don't recurse into every container type #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b5698a updated self.container_type() to recognize OLE as an additional format, but this broke the `-zip` switch. The method was being used to identify two different categories of formats: 1. Container formats which need to be matched against the PRONOM container signatures in order to get more precise matches; and 2. Container formats which can be recursed into via the `-zip` switch in order to identify the formats of their contents. FIDO supports OLE for the former but not the latter, and since OLE is usually not interesting for its contents, it doesn't make sense to support recursing into it. This commit adds a new method which differentiates whether FIDO is interested in recursing into a format, not merely whether it *is* a container format, and updates the `-zip` path to check using it. Fixes #72.
|
👍 |
|
I tested with the same .doc file, looks good: fido -zip ~/Downloads/embedded_video_quicktime.doc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1b5698a updated
self.container_type()to recognize OLE as an additional format, but this broke the-zipswitch. The method was being used to identify two different categories of formats:-zipswitch in order to identify the formats of their contents.FIDO supports OLE for the former but not the latter, and since OLE is usually not interesting for the format of its contents, it doesn't make sense to support recursing into it.
This commit adds a new method which differentiates whether FIDO is interested in recursing into a format, not merely whether it is a container format, and updates the
-zippath to check using it.Fixes #72.