Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Fields shoud be declared at the top of the class #484

Merged
merged 14 commits into from
Oct 18, 2019
Merged

Fixed: Fields shoud be declared at the top of the class #484

merged 14 commits into from
Oct 18, 2019

Conversation

nvanderperren
Copy link
Contributor

fixes #416

@nvanderperren
fix: fields declared at top of class ärseException.java HTML module
cead7da
@nvanderperren
fix: fields declared at top of class ParseHtmlTokenManager HTML module
2b054d3
@nvanderperren
fix: fields declared at top of class ParseHtmlTokenManager HTML modul…
fa2fc48 
…e (2)
@nvanderperren
fix: fields declared at top of class JpegStrings JPEG module
c9c992f
@nvanderperren
fix: fields declared at top of class JP2Strings JPEG2000 module
8d70e99
@nvanderperren
fix: fields declared at top of class PdfStrings PDF module
ca77808
@nvanderperren
fix: fields declared at top of class WaveStrings WAVE module
f798a55
@nvanderperren
fix: fields declared at top of class HtmlSpecialToken HTML module
fa1228b
@nvanderperren
fix: fields declared at top of class OdfModule and ManifestHandler IT…
ed75ce3 
…/ENG/JHOVE
@nvanderperren
fix: fields declared at top of class PngModule IT/ENG/JHOVE
af88852
@nvanderperren
fix: fields declared at top of class GifStrings of GifModule
84858b0
@nvanderperren
fix: fields declared at top of class MetaHandles OdfModule IT/ENG/JHOVE
e29894c
@nvanderperren
fix: fields declared at top of class AiffStrings of AiffModule
dc2d156
@codecov
Copy link

codecov bot commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #484 into integration will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             integration     #484   +/-   ##
==============================================
  Coverage          49.54%   49.54%           
  Complexity           974      974           
==============================================
  Files                 55       55           
  Lines               7666     7666           
  Branches            1392     1392           
==============================================
  Hits                3798     3798           
  Misses              3412     3412           
  Partials             456      456

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85367f0...e4e5ed7. Read the comment docs.

@carlwilson carlwilson added bug A product defect that needs fixing P3 Low priority bugs labels Oct 18, 2019
@carlwilson carlwilson added this to the v1.24-m4 Release milestone Oct 18, 2019
@carlwilson carlwilson self-requested a review October 18, 2019 11:33
@carlwilson carlwilson merged commit 8b87800 into openpreserve:integration Oct 18, 2019
@nvanderperren nvanderperren deleted the issue/416 branch November 6, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlwilson carlwilson carlwilson approved these changes

Assignees

@nvanderperren nvanderperren

Labels
bug A product defect that needs fixing P3 Low priority bugs
Projects
None yet
Milestone
No milestone
2 participants
@nvanderperren @carlwilson