Fixed: duplicate if statements #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## integration #505 +/- ##
================================================
+ Coverage 49.69% 49.7% +0.01%
Complexity 987 987
================================================
Files 55 55
Lines 7750 7748 -2
Branches 1406 1406
================================================
Hits 3851 3851
+ Misses 3435 3433 -2
Partials 464 464
Continue to review full report at Codecov.
|
carlwilson
requested changes
Oct 22, 2019
There was a problem hiding this comment.
1 very minor change requested but that apart a thing of beauty, thanks. Went a bit operator blind checking the logic. Thanks muchly @nvanderperren
| } | ||
| // This shouldn't happen | ||
| return false; | ||
| // This shouldn't happen |
There was a problem hiding this comment.
should be fixed!
carlwilson
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to solve #418