Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Jhove compilable with JDK 9.0 and latter #514

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

tledoux
Copy link
Contributor

@tledoux tledoux commented Oct 25, 2019

Add explicit import of edu.harvard.hul.ois.jhove.Module
Make XmlHandlerTest work independently of the order of execution
Fixes #508

Add explicit import of edu.harvard.hul.ois.jhove.Module
Make XmlHandlerTest work independently of the order of execution
Fixes openpreserve#508
@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #514 into integration will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             integration     #514     +/-   ##
================================================
+ Coverage           49.7%   49.91%   +0.2%     
  Complexity           987      987             
================================================
  Files                 55       55             
  Lines               7748     7800     +52     
  Branches            1406     1409      +3     
================================================
+ Hits                3851     3893     +42     
- Misses              3433     3441      +8     
- Partials             464      466      +2
Impacted Files Coverage Δ Complexity Δ
...main/java/edu/harvard/hul/ois/jhove/JhoveBase.java 41.79% <ø> (ø) 41 <0> (ø) ⬇️
.../edu/harvard/hul/ois/jhove/handler/XmlHandler.java 62.91% <ø> (+0.09%) 276 <0> (ø) ⬇️
...edu/harvard/hul/ois/jhove/handler/TextHandler.java 0.55% <ø> (ø) 2 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a277f8...f47831b. Read the comment docs.

Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am back on these now until the end of the week. This has a nasty conflict I'll need to look at close up to resolve first but will do so soon.

@carlwilson carlwilson merged commit f47831b into openpreserve:integration Dec 10, 2019
@tledoux tledoux deleted the issue508 branch December 10, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Reference to Module is ambiguous in Java version > 8
2 participants