Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Json output. #515

Merged
merged 9 commits into from
Dec 10, 2019
Merged

Provide Json output. #515

merged 9 commits into from
Dec 10, 2019

Conversation

tledoux
Copy link
Contributor

@tledoux tledoux commented Oct 27, 2019

Add new dependencies to generate valid json:
groupId=javax.json,artifactId=javax.json-api
groupId=org.glassfish, artifactId=javax.json
Fixes #385
Doesn't support mix version 0.2.

@tledoux
Copy link
Contributor Author

tledoux commented Oct 27, 2019

Codacy finds too many magic strings... 😒
Travis discovered a new handle 😉 : I really need to learn how to modify the regression tests 😩

Add new dependencies to generate valid json:
    groupId=javax.json,artifactId=javax.json-api
    groupId=org.glassfish, artifactId=javax.json
Fixes openpreserve#385
Doesn't support mix version 0.2.
@codecov
Copy link

codecov bot commented Oct 28, 2019

Codecov Report

Merging #515 into integration will decrease coverage by 3.7%.
The diff coverage is 21.83%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #515      +/-   ##
=================================================
- Coverage          49.44%   45.73%   -3.71%     
- Complexity           984     1046      +62     
=================================================
  Files                 56       56              
  Lines               7768     9165    +1397     
  Branches            1409     1650     +241     
=================================================
+ Hits                3841     4192     +351     
- Misses              3457     4429     +972     
- Partials             470      544      +74
Impacted Files Coverage Δ Complexity Δ
...main/java/edu/harvard/hul/ois/jhove/JhoveBase.java 43.34% <100%> (+1.81%) 43 <0> (+2) ⬆️
...src/main/java/edu/harvard/hul/ois/jhove/Agent.java 46.82% <100%> (+1.29%) 14 <1> (+1) ⬆️
...edu/harvard/hul/ois/jhove/handler/JsonHandler.java 21.44% <21.44%> (ø) 43 <43> (?)
...in/java/edu/harvard/hul/ois/jhove/InfoMessage.java 41.17% <0%> (-11.77%) 4% <0%> (-1%)
...ain/java/edu/harvard/hul/ois/jhove/ModuleBase.java 50.69% <0%> (-0.11%) 70% <0%> (-3%)
...edu/harvard/hul/ois/jhove/handler/TextHandler.java 0.54% <0%> (-0.01%) 2% <0%> (ø)
...n/java/edu/harvard/hul/ois/jhove/ChecksumType.java 100% <0%> (ø) 3% <0%> (ø) ⬇️
...a/edu/harvard/hul/ois/jhove/NisoImageMetadata.java 75.64% <0%> (ø) 182% <0%> (ø) ⬇️
...src/main/java/edu/harvard/hul/ois/jhove/Utils.java
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e9211...6285cf4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON output
2 participants