Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks the range of the orientation tag to be 1-9, and forces value 9… #914

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

tledoux
Copy link
Contributor

@tledoux tledoux commented Mar 8, 2024

… (unknown) in XML and JSON output to remind valid.

Fixes #913

… (unknown) in XML and JSON output to remind valid.

Fixes openpreserve#913
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 47.04%. Comparing base (838126f) to head (4510a44).
Report is 1 commits behind head on integration.

Files Patch % Lines
.../edu/harvard/hul/ois/jhove/handler/XmlHandler.java 14.28% 3 Missing and 3 partials ⚠️
...edu/harvard/hul/ois/jhove/handler/JsonHandler.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             integration     #914      +/-   ##
=================================================
- Coverage          47.06%   47.04%   -0.03%     
  Complexity          1103     1103              
=================================================
  Files                 57       57              
  Lines               9083     9087       +4     
  Branches            1623     1625       +2     
=================================================
  Hits                4275     4275              
- Misses              4278     4280       +2     
- Partials             530      532       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tledoux tledoux requested a review from carlwilson March 8, 2024 13:24
@carlwilson carlwilson added the bug A product defect that needs fixing label Mar 8, 2024
@carlwilson carlwilson modified the milestones: JHOVE 1.30, JHOVE 1.32 Mar 8, 2024
@carlwilson carlwilson added the P1 High priority issues to be scheduled in the upcoming release label Mar 28, 2024
@carlwilson carlwilson merged commit bf9b7da into openpreserve:integration Aug 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orientation info in EXIF is not checked and can generate invalid XML
2 participants