This repository has been archived by the owner on Jan 1, 2020. It is now read-only.
Resize loop #9
Merged
Resize loop #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now contains a check that the width has actually changed before setting the width. This stops an infinite loop of window.resize events being thrown in IE if you set the grid width inside a window.resize event.
meh-uk
added a commit
that referenced
this pull request
Jan 6, 2015
Actually given I've see this exact issue in two entirely separate implementations of jqGrid several years apart, and I can't see any possible harm from it - I'm going to merge this, unless @OlegKi has a better solution :).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue (only in IE 8 AFAIK, its an old one) where resizing the grid from the window resize event caused an infinite loop where resizing the loop then called the window resize event again.
This protects against that.