Use the new lua UserInterface in the missions #8273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| local percentage = 100 - VillageHousesLeft() * 10 | ||
| local color = GetColor(percentage) | ||
| UserInterface.SetMissionText(percentage .. "% of the village destroyed.", color) | ||
| end |
There was a problem hiding this comment.
You could move this into an OnKilled trigger set on every house in the village. Then this wouldn't need to run every tick.
abcdefg30
force-pushed
the
luaUI
branch
2 times, most recently
from
d514c87
to
103a19e
Compare
| @@ -345,6 +368,7 @@ InitMission = function() | |||
| end) | |||
|
|
|||
| Trigger.AfterDelay(DateTime.Seconds(1), function() Media.PlaySpeechNotification(allies, "MissionTimerInitialised") end) | |||
| TimerColor = HSLColor.New(115, 240, 130) | |||
There was a problem hiding this comment.
Player.Color may be more convenient here. You just need to set it up with the Lua API in the PlayerProperties.cs.
|
Updated.
|
|
By the way: The facing defaults are from our old lua API. |
|
Can you split off the facings into another pull request? They seem to be unused and unrelated here. |
|
Done: #8275 |
|
This is a well thought through enhancement of the Lua API. 👍 I could not find any regressions during testing. ✅ |
|
👍 Looks good to me |
obrakmann
added a commit
that referenced
this pull request
May 27, 2015
Use the new lua UserInterface in the missions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.