Integrate global chat with the lobby. #9692
Conversation
|
The two 'disconnect' buttons right next to each other irk me. Can we change the label on one of them (I'd probably go with 'Leave [match|game|lobby]')? |
|
In TD we use "Back" for skirmish, and "Leave Game" for MP. I never noticed that RA used different terminology. I'll change them to match TD, and then use "Leave Chat" for the IRC button. |
pchote
force-pushed
the
lobby-irc
branch
2 times, most recently
from
05e83fc
to
5efa879
Compare
|
Updated. |
|
this works 👍 |
|
Rebased. |
|
What do you think about making the buttons all the same width? It pleases my OCD ;)
Diff: index bf0c684..de45eb0 100644
--- a/mods/ra/chrome/lobby.yaml
+++ b/mods/ra/chrome/lobby.yaml
@@ -124,16 +124,16 @@ Background@SERVER_LOBBY:
Width: PARENT_RIGHT - 40
Height: 229
Button@START_GAME_BUTTON:
- X: PARENT_RIGHT - WIDTH - 150
+ X: PARENT_RIGHT - WIDTH - 205
Y: PARENT_BOTTOM - HEIGHT - 20
- Width: 120
+ Width: 172
Height: 25
Text: Start Game
Font: Bold
Button@DISCONNECT_BUTTON:
X: PARENT_RIGHT - WIDTH - 20
Y: PARENT_BOTTOM - HEIGHT - 20
- Width: 120
+ Width: 172
Height: 25
Text: Leave Game
Font: Bold |
|
The buttons are matched to the map chooser, and (will be matched to) the new server browser, so that ends up being a rather major style change. The current button widths / positions are consistent across most of the UI panels. |
|
hmm... ok. maybe we can come up with another solution eventually. for now, 👍 |
Integrate global chat with the lobby.
The next step towards #9451. A future PR will add unread message counts to the tab labels, but that depends on some wider widget refactoring that will come in the next PR.