Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in the Car Operations Menu for the lines with brake information #860

Merged
merged 5 commits into from Sep 5, 2023
Merged

Changes in the Car Operations Menu for the lines with brake information #860

merged 5 commits into from Sep 5, 2023
+165 −24

Conversation

sweiland-openrails
Copy link
Contributor

Changes in the Car Operations Menu (part of the Train Operations Window):

Toggle Handbrake to set / Toggle Handbrake to off
Toggle Brake Hose to connected / Toggle Brake Hose to unconnected
Open Front Angle Cock / Close Front Angle Cock
Open Front Angle Cock / Close Rear Angle Cock
Open Front Bleed Off Value / Close Rear Bleed Off Value

Lines now show the action which will take place when pressing a line. And non valid actions will be grayed out.

And also a small change in the BRAKE INFORMATION HUD. Where sometimes an unset handbrake is not shown as 0%, sometimes it does. Now it always does show up as 0% (unset) or 100% (set).

see http://www.elvastower.com/forums/index.php?/topic/37062-proposal-f9-train-operations/page__p__296373__hl__%2Btrain+%2Boperations__fromsearch__1#entry296373

and https://trello.com/c/Bva4dtYW

@sweiland-openrails sweiland-openrails changed the title Changes in the Car Operations Menu (part of the Train Operations Window) for the lines with brake information Changes in the Car Operations Menu for the lines with brake information Aug 7, 2023
@sweiland-openrails sweiland-openrails added enhancement New feature or request for-unstable Special label to include a pull request in the Unstable Version labels Aug 7, 2023
twpol pushed a commit that referenced this pull request Aug 7, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 12 pull requests
49647b0 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at 076c77a: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at d6d0c82: Steam adhesion bug#1
- Pull request #860 at 91f0a35: Changes in the Car Operations Menu for the lines with brake information
@SteelFill
Copy link
Contributor

I like this change, makes it much more obvious what my actions will do, but I have a few style considerations that could help.

  • Capitalization is inconsistent. Normally in this menu, every word is capitalized, but the new text introduced here doesn't always follow that trend. (For example, "Toggle Handbrake to set". Following the trend set, "Set" should be capitalized.
  • It would be better to change the terminology to not use "toggle" as the action word when another action is simultaneously specified. ("Toggle Handbrake to Set" just sounds clunky. "Set Handbrake" is a much shorter way to say the same thing.)
  • For continued consistency, it would be nice to see similar work done for the remaining commands. In particular, "Toggle MU Connection" -> "Connect/Disconnect MU Cable", "Toggle Power" -> "Switch Power On/Off", "Toggle Battery Switch" -> "Switch Battery On/Off", "Toggle Electric Train Supply Connection" -> "Connect/Disconnect Electric Train Supply Cable"

@sweiland-openrails
Copy link
Contributor Author

hi Phillip,

Thanks for looking into this. I fully agree with your style changes. Now I have:

Unset Handbrake/Set Handbrake
Disconnect Brake Hose/Connect Brake Hose
Close Front Angle Cock/Open Front Angle Cock
Close Rear Angle Cock/Open Rear Angle Cock
Close Bleed Off Valve/Open Bleed Off Valve

The rest I'll look into after this change has been accepted. For shunting the brakes are important. The rest is less. And the results for these actions are less clear, I guess. Still have to look into this.

twpol pushed a commit that referenced this pull request Aug 8, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 12 pull requests
510f649 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at 076c77a: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at d6d0c82: Steam adhesion bug#1
- Pull request #860 at 6a3f86f: Changes in the Car Operations Menu for the lines with brake information
twpol pushed a commit that referenced this pull request Aug 10, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 12 pull requests
e1dd171 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at 076c77a: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at 6a3f86f: Changes in the Car Operations Menu for the lines with brake information
twpol pushed a commit that referenced this pull request Aug 10, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 13 pull requests
5362994 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at 076c77a: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at 6a3f86f: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at d652a06: Curve friction#1
twpol pushed a commit that referenced this pull request Aug 10, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 13 pull requests
53e5caf 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at 076c77a: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at 6a3f86f: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at d2e63f1: Curve friction#1
twpol pushed a commit that referenced this pull request Aug 11, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 13 pull requests
8ea9ec4 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at 076c77a: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at 6a3f86f: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
@sweiland-openrails
Copy link
Contributor Author

sweiland-openrails commented Aug 13, 2023 •
edited

I'm always a bit confused about the Brake Hose entry in the Car Operations Menu, is it in front or at the rear of the car? Therefore I've changed this entry into two entries: Connect Front Brake Hose and Connect Rear Brake Hose. Just the menu changed, no data changes. If for the above example you click Disconnect Rear Brake Hose the brake hose between 0-0 and 0-1 gets disconnected. Seems easier to me. And more realistic.
I still have to change the documentation accordingly.

twpol pushed a commit that referenced this pull request Aug 13, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 13 pull requests
cef36a1 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at 076c77a: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at 82ab6ce: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
twpol pushed a commit that referenced this pull request Aug 13, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 14 pull requests
be22425 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at 076c77a: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at 82ab6ce: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
Csantucci added a commit to Csantucci/openrails that referenced this pull request Aug 15, 2023
@Csantucci
Merge master branch openrails#860 'TrainOperationsWindowBrakeChanges'…
9ec4ac1 
… by sweiland into OR_NewYear_MG_NoWD
twpol pushed a commit that referenced this pull request Aug 15, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 14 pull requests
548a908 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at 30e7413: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at 076c77a: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
twpol pushed a commit that referenced this pull request Aug 15, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 14 pull requests
f9f500b 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at 076c77a: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
twpol pushed a commit that referenced this pull request Aug 17, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 15 pull requests
0b9ed75 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at cb3f1c0: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at fe901d3: Alternate preset 3D cabviewpoints, see TrelloBox https://trello.com/c…
twpol pushed a commit that referenced this pull request Aug 19, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 15 pull requests
5c9cc23 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at cb3f1c0: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
twpol pushed a commit that referenced this pull request Aug 19, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 16 pull requests
6e0232d 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at cb3f1c0: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #865 at bc03dd8: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 20, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 16 pull requests
373d07e 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at cb3f1c0: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #865 at 079300b: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 20, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 16 pull requests
17d9306 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at cb3f1c0: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #865 at 8da038f: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 20, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 16 pull requests
c7486f7 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at cb3f1c0: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #865 at 8918de1: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 20, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 16 pull requests
f1f3f27 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at cb3f1c0: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #865 at 7d62bb2: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 21, 2023
@openrails-bot
Automatic merge of T1.5.1-535-g2f57132ee and 16 pull requests
ae94dd3 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #856 at b9742e1: Add Alternate Syntax for Confusing Tokens
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #858 at bbaeeba: Fix wheel animation problems
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #865 at 7d62bb2: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 21, 2023
@openrails-bot
Automatic merge of T1.5.1-542-ga8a4343d9 and 15 pull requests
63fa159 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at cfdada3: Fixes for Undesired Emergency Applications
- Pull request #865 at 7d62bb2: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 22, 2023
@openrails-bot
Automatic merge of T1.5.1-542-ga8a4343d9 and 15 pull requests
62f936f 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 30d7b53: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at cfdada3: Fixes for Undesired Emergency Applications
- Pull request #865 at bfba8f0: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 23, 2023
@openrails-bot
Automatic merge of T1.5.1-542-ga8a4343d9 and 15 pull requests
5e67d43 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 8a7df84: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at cfdada3: Fixes for Undesired Emergency Applications
- Pull request #865 at bfba8f0: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 24, 2023
@openrails-bot
Automatic merge of T1.5.1-542-ga8a4343d9 and 15 pull requests
e327934 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 8a7df84: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 2c39260: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 7d0f327: Fixes for Undesired Emergency Applications
- Pull request #865 at bfba8f0: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 24, 2023
@openrails-bot
Automatic merge of T1.5.1-542-ga8a4343d9 and 15 pull requests
de5bf9c 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 8a7df84: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 589e716: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 7d0f327: Fixes for Undesired Emergency Applications
- Pull request #865 at bfba8f0: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 24, 2023
@openrails-bot
Automatic merge of T1.5.1-542-ga8a4343d9 and 15 pull requests
573e2fc 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 8a7df84: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 589e716: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 7d0f327: Fixes for Undesired Emergency Applications
- Pull request #865 at 705126e: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 25, 2023
@openrails-bot
Automatic merge of T1.5.1-542-ga8a4343d9 and 15 pull requests
58d7940 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 8a7df84: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 589e716: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 705126e: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 25, 2023
@openrails-bot
Automatic merge of T1.5.1-542-ga8a4343d9 and 15 pull requests
65af7b8 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 8a7df84: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #861 at 8d70199: Curve friction#1
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 705126e: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 25, 2023
@openrails-bot
Automatic merge of T1.5.1-550-ge91bba953 and 14 pull requests
4b97ee5 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #821 at cc3af66: Adds suppression of safety valves
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at a9760ec: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 705126e: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 25, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 13 pull requests
89c91ae 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 705126e: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 26, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 13 pull requests
a300e37 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 3097086: Dispatcher window improvements
twpol pushed a commit that referenced this pull request Aug 26, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
efee2ae 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 3097086: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
cjakeman
cjakeman reviewed Aug 27, 2023
View reviewed changes
Copy link
Contributor

@cjakeman cjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Siebren,

I've approved your Trello card, so any dev is free now to review, approve and merge this PR.

Thanks,
Chris

twpol pushed a commit that referenced this pull request Aug 27, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
b812b4d 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 2fed4b9: Fixes for Undesired Emergency Applications
- Pull request #865 at 9d8513a: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
twpol pushed a commit that referenced this pull request Aug 27, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
e8505cb 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 9d8513a: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
@sweiland-openrails
Copy link
Contributor Author

hi Phillip,

Since you know already about this change, could you review my pull request?

thanks, Siebren.

@SteelFill
Copy link
Contributor

hi Phillip,

Since you know already about this change, could you review my pull request?

thanks, Siebren.

Got a busy day today, but I can take a look at the code later.

twpol pushed a commit that referenced this pull request Aug 28, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
44c05de 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at fff2560: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
SteelFill
SteelFill reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@SteelFill SteelFill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From testing, this is working as intended and I have no concerns about the code. Look at that typo in the documentation though.

Next, someone on the OR team will have to approve this.

Source/Documentation/Manual/driving.rst Outdated
- to toggle the angle cocks on the air hoses at either end of the car
between open and closed;
- to toggle the bleed valve on the car to vent the air pressure from the
- to connect of disconnect the battery;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: I think you meant 'connect or disconnect'

Also, I would say that 'enable or disable the battery switch' is more appropriate than 'connecting' the battery

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the documentation accordingly. Thanks for looking into this,

twpol pushed a commit that referenced this pull request Aug 30, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
b2046ed 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 0e963aa: Steam adhesion bug#1
- Pull request #860 at d2b8a52: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
twpol pushed a commit that referenced this pull request Aug 30, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 14 pull requests
1335eec 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 0e963aa: Steam adhesion bug#1
- Pull request #860 at 82a584a: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
twpol pushed a commit that referenced this pull request Aug 31, 2023
@openrails-bot
Automatic merge of T1.5.1-553-g4b9199858 and 15 pull requests
1855c90 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #859 at 0e963aa: Steam adhesion bug#1
- Pull request #860 at 82a584a: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at a6cbc52: Fix Articulation For 0-Axle Train Cars
- Pull request #868 at 1b42d4c: Bug  fix for Exhaust of non-lead diesels is not correct https://bugs.launchpad.net/or/+bug/2033621
SteelFill
SteelFill approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@SteelFill SteelFill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, and as a new OpenRails team member, I can approve your changes.

Approved

twpol pushed a commit that referenced this pull request Sep 5, 2023
@openrails-bot
Automatic merge of T1.5.1-561-g5e31b2390 and 13 pull requests
31ca054 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #860 at 82a584a: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
twpol pushed a commit that referenced this pull request Sep 5, 2023
@openrails-bot
Automatic merge of T1.5.1-561-g5e31b2390 and 14 pull requests
cb43104 
- Pull request #757 at 98dd1a7: Unify RailDriver code implementations
- Pull request #831 at 61bbf43: poor mans switch panel on tablet
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters
- Pull request #841 at 410a585: https://blueprints.launchpad.net/or/+spec/animating-trainset-windows
- Pull request #853 at d05f581: Notify out of focus
- Pull request #855 at b39e5d8: Adds new route from TrainSimulations
- Pull request #857 at 9afc8c3: Adding Air Flow Meters
- Pull request #860 at 82a584a: Changes in the Car Operations Menu for the lines with brake information
- Pull request #862 at 489f261: Fix engine leak problem
- Pull request #863 at a34b857: Alternate preset 3D cabviewpoints
- Pull request #864 at 18c5481: Fixes for Undesired Emergency Applications
- Pull request #865 at 776d6df: Dispatcher window improvements
- Pull request #866 at c15333e: Fix Articulation For 0-Axle Train Cars
- Pull request #870 at 5cb32fa: Fix water restore
@sweiland-openrails
Copy link
Contributor Author

thanks Phillip and good to have you in the team.

@sweiland-openrails sweiland-openrails merged commit efb91a4 into openrails:master Sep 5, 2023
1 of 3 checks passed
@sweiland-openrails sweiland-openrails deleted the TrainOperationsWindowBrakeChanges branch September 23, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjakeman cjakeman cjakeman left review comments

@SteelFill SteelFill SteelFill approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request for-unstable Special label to include a pull request in the Unstable Version
Milestone
No milestone
3 participants
@sweiland-openrails @SteelFill @cjakeman