Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable disable AWS discovery on a per-service basis via configuration #7

Closed
kickroot opened this issue Mar 23, 2021 · 0 comments
Closed

Enable disable AWS discovery on a per-service basis via configuration #7

kickroot opened this issue Mar 23, 2021 · 0 comments
Assignees
@kickroot
Labels
aws discovery good first issue Good for newcomers
Milestone
1.0

Comments

@kickroot
Copy link
Contributor

We need to be able to toggle via configuration which AWS services are enabled for scanning. Not all users will want to scan all services.

How
Edit https://github.com/openraven/magpie/blob/main/magpie-aws/src/main/java/io/openraven/magpie/plugins/aws/discovery/AWSDiscoveryConfig.java to add an enabledServices array.

Filter disabled plugins here https://github.com/openraven/magpie/blob/main/magpie-aws/src/main/java/io/openraven/magpie/plugins/aws/discovery/AWSDiscoveryPlugin.java#L50.

Semantics
An empty values for enabledServices indicates that all services should be scanned. If the array contains one or more service names then only those services will be scanned.
@kickroot kickroot added this to the 1.0 milestone Mar 23, 2021
@kickroot kickroot added the good first issue Good for newcomers label Mar 23, 2021
@kickroot kickroot self-assigned this Mar 25, 2021
kickroot added a commit that referenced this issue Mar 25, 2021
@kickroot
Fix for #7 (AWS per-service enablement), configuration improvements, …
3cd3d70 
…reduced logging clutter
@kickroot kickroot mentioned this issue Mar 25, 2021
Merged
kickroot added a commit that referenced this issue Mar 25, 2021
@kickroot
Fix for #7 (AWS per-service enablement), configuration improvements, …
3b5149a 
…reduced logging clutter (#16)

Co-authored-by: Jason Nichols <jason@openraven.com>
belosh59 pushed a commit that referenced this issue Aug 23, 2021
@PrzemyslawTusinski @stefansjfw
Added supported services list to readme (#7)
1922485 
* Added supported services list to readme

* Update README.md

Co-authored-by: Stefan Markovic <57057282+stefansjfw@users.noreply.github.com>

* Update README.md

Co-authored-by: Stefan Markovic <57057282+stefansjfw@users.noreply.github.com>

Co-authored-by: Stefan Markovic <57057282+stefansjfw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kickroot kickroot

Labels
aws discovery good first issue Good for newcomers
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@kickroot