Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Add sorting activities to the main page #47

Closed
wojtekbu opened this issue Dec 10, 2018 · 5 comments
Closed

Add sorting activities to the main page #47

wojtekbu opened this issue Dec 10, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@wojtekbu
Copy link
Collaborator

The parent ticket can be found here: #11
According to the mock https://user-images.githubusercontent.com/12927553/48443971-55f41d00-e758-11e8-96ad-6596c7a6092c.png add sorting functionality.

Default sort should be based on the number and age of updates of matching records in partners’ databases.

Sorting options:

  • the number of updates,
  • age of updates.
@johnhbenetech
Copy link
Collaborator

also see #18 for more info

@wojtekbu wojtekbu self-assigned this Jan 25, 2019
@wojtekbu wojtekbu added Story parent issue with short requirements or requests written from the perspective of an end user and removed Story parent issue with short requirements or requests written from the perspective of an end user labels Jan 25, 2019
oskarhinc added a commit that referenced this issue Jan 25, 2019
#47: Provider's jobs start an hour after app deploy
@johnhbenetech johnhbenetech added the enhancement New feature or request label Jan 29, 2019
wojtekbu added a commit that referenced this issue Feb 6, 2019
wojtekbu added a commit that referenced this issue Feb 7, 2019
oskarhinc added a commit that referenced this issue Feb 7, 2019
#47: Added sorting to the main page
@wojtekbu wojtekbu assigned oskarhinc and unassigned wojtekbu Feb 7, 2019
@oskarhinc
Copy link
Contributor

oskarhinc commented Feb 8, 2019

@wojtekbu I've verified it, and it's working well, but I've got some suggestions:

  1. I think it should be available to determine if the sorting is ascending or descending, even as different dropdown options:
    -by xyz (ascending)
    -by xyz (descending)

  2. The layout of the button could be quite different (it should not stick with the first activity on the bottom). Also for me, it's more intuitive for sort button to be floated right, but I'll leave it to you. It could also be in-line with "Recent ServiceNet activity" title.

  3. I know it looks different than in the mock but I think it's a good solution to display the selected option all the time (like it's done for example on the amazon.com:
    screenshot from 2019-02-08 13-56-06

@johnhbenetech should we apply those suggestions?

@johnhbenetech
Copy link
Collaborator

As discussed in our Call:

  • Design should be more in line with mock-up. Keep dropdown on same level as title and float right

  • Sort Options should be:
    **Recently Updated
    **Recommended

  • No need for ascending/descending option. Default should be newest to oldest, most to least.

Recommended sort at first will just be sorted by Number of Updated fields (most to least). In the future we will add weighting to fields updated, and weighting to updates over existing conflicts.

@oskarhinc oskarhinc assigned wojtekbu and unassigned oskarhinc Feb 11, 2019
oskarhinc added a commit that referenced this issue Feb 15, 2019
#212: Removed Cache from admin's edit user page
wojtekbu added a commit that referenced this issue Feb 15, 2019
* Adjusted sort dropdown menu
@wojtekbu wojtekbu assigned oskarhinc and unassigned wojtekbu Feb 15, 2019
oskarhinc added a commit that referenced this issue Feb 15, 2019
#47: Adjusted main view to match the mock
@oskarhinc
Copy link
Contributor

The sorting looks as expected, but the Last updated date seems to be always now(). @wojtekbu do you know why it might be happening? If so, could you create a ticket for that?

@oskarhinc oskarhinc assigned wojtekbu and unassigned oskarhinc Feb 15, 2019
@wojtekbu
Copy link
Collaborator Author

@oskarhinc It looks like conflicts cannot find a date for conflicted objects. Here is a solution #239

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants