0.7.14rc1 fails to build against nginx 1.3.11 with latest SPDY patch (58) applied

[chrislea]

If you apply the latest SPDY patch (currently 58) to Nginx 1.3.11, the 0.7.14rc1 lua module fails to build with the following error:

gcc -c -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -Wall -D_FORTIFY_SOURCE=2  -DNDK_SET_VAR  -I src/core -I src/event -I src/event/modules -I src/os/unix -I /tmp/buildd/nginx-1.3.11/debian/modules/nginx-development-kit/objs -I objs/addon/ndk -I /usr/include/lua5.1 -I /tmp/buildd/nginx-1.3.11/debian/modules/lua-nginx-module-0.7.14rc1/src/api -I /tmp/buildd/nginx-1.3.11/debian/modules/nginx-http-push/src -I /tmp/buildd/nginx-1.3.11/debian/openssl-1.0.1c/.openssl/include -I /usr/include/libxml2 -I objs -I src/http -I src/http/modules -I src/http/modules/perl -I /tmp/buildd/nginx-1.3.11/debian/modules/nginx-development-kit/src -I src/mail \
        -o objs/addon/src/ngx_http_lua_socket_tcp.o \
        /tmp/buildd/nginx-1.3.11/debian/modules/lua-nginx-module-0.7.14rc1/src/ngx_http_lua_socket_tcp.c
/tmp/buildd/nginx-1.3.11/debian/modules/lua-nginx-module-0.7.14rc1/src/ngx_http_lua_socket_tcp.c: In function 'ngx_http_lua_socket_tcp_connect':
/tmp/buildd/nginx-1.3.11/debian/modules/lua-nginx-module-0.7.14rc1/src/ngx_http_lua_socket_tcp.c:444:18: error: 'ngx_connection_t' has no member named 'single_connection'

It looks like that field was removed from the structure as this is in the patch:

diff -urN nginx-1.3.11.orig/src/core/ngx_connection.h nginx-1.3.11/src/core/ngx_connection.h
--- nginx-1.3.11.orig/src/core/ngx_connection.h 2012-07-30 05:27:06.000000000 -0700
+++ nginx-1.3.11/src/core/ngx_connection.h      2013-01-15 11:17:24.804357142 -0800
@@ -152,7 +152,6 @@

     unsigned            log_error:3;     /* ngx_connection_log_error_e */

-    unsigned            single_connection:1;
     unsigned            unexpected_eof:1;
     unsigned            timedout:1;
     unsigned            error:1;

I unfortunately don't have the skillset to try and fix this, but I wanted to bring it to somebody's attention. Thanks!

[agentzh]

Thank you for the report! This is a known issue. I'll look into this shortly.

[agentzh]

Already fixed in master. Please try out v0.7.14rc2:

https://github.com/chaoslawful/lua-nginx-module/tags/

[agentzh]

Thank you for your feedback. Consider it resolved :)

[maanas]

I m getting same error in nginx 1.4.0 stable

[agentzh]

@maanas which verison of ngx_lua are you using? If you're not using the latest version, then try upgrading your ngx_lua module.