Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua-releng: 5.1 version luac treat bit module as global variable #18

Closed
Gerrard-YNWA opened this issue Mar 9, 2018 · 1 comment
Closed

Comments

@Gerrard-YNWA
Copy link

Gerrard-YNWA commented Mar 9, 2018

minimal case

local band = bit.band

lua-releng use 5.1 version luac interperter

lua-releng test.lua 
Checking use of Lua global variables in file test.lua...
	op no.	line	instruction	args	; code
	1	[1]	GETGLOBAL	0 -1	; bit

should we need to ignore this?

@agentzh agentzh closed this as completed in cf08d28 Mar 9, 2018
@agentzh
Copy link
Member

agentzh commented Mar 9, 2018

@Gerrard-YNWA Fixed in the lj-releng tool. It's not right to ignore bit in lua-releng since it is not a standard module in Lua 5.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants