Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARR: Desk reject verification flag improperly set to false #2129

Closed
haroldrubio opened this issue May 3, 2024 · 1 comment
Closed

ARR: Desk reject verification flag improperly set to false #2129

haroldrubio opened this issue May 3, 2024 · 1 comment
Assignees

Comments

@haroldrubio
Copy link
Member

There are several notes that can indicate a desk rejection to the EiCs: Reviewer_Checklist, Action_Editor_Checklist, Official_Review, and Meta_Review

If one of these is posted without a field being violated, the process function checks the rest of the replies with the same invitation for violations. If no violations are found for those replies, then the submission's flag is set to false.

The issue is that the process function does not have information about the replies with different invitations, and it may unflag a submission because there are no checklists with violation fields set, but there may be official reviews with violation fields set.

Example: An official review has a field that raises the flag for desk rejection. An action editor checklist is then submitted with no fields indicating that the flag should be raised, and there are no other action editor checklists that indicate the flag should be raised either, so the flag is set to false even though the official review says that the flag should be true.

@haroldrubio haroldrubio self-assigned this May 3, 2024
@haroldrubio
Copy link
Member Author

Going to deprecate this flag, see #2139

@haroldrubio haroldrubio closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant