-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename tasks rewriteWarn to rewriteDryRun and rewriteFix to rewriteRun #25
Conversation
Task rewriteWarnAll = tasks.create("rewriteWarn", taskClosure(task -> { | ||
Task rewriteDryRunAll = tasks.create("rewriteDryRun", taskClosure(task -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the old "warn" name working for now, just in case someone uses it. Create another task named rewriteWarn that depends on rewriteDryRun
. We'll leave the aliases in for a few releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify: are we just aliasing the command rewriteWarn
, or do we also need to alias rewriteWarn{SourceSet}
, e.g. users running rewriteWarnTest
, rewriteWarnMain
, etc.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably just rewriteWarn
. I think it unlikely that anyone will have bothered with the more granular per-sourceSet tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for good measure I included the specific source sets, too.
984a0b8
to
b363c0a
Compare
b363c0a
to
0e52673
Compare
(going to close this PR outright and will open a separate one renaming both rewriteWarn and rewriteFix in the same PR and without aliasing) |
closes #20
should likely be followed by openrewrite/rewrite-maven-plugin#110