Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename tasks rewriteWarn to rewriteDryRun and rewriteFix to rewriteRun #25

Closed
wants to merge 2 commits into from

Conversation

aegershman
Copy link
Contributor

@aegershman aegershman commented Apr 1, 2021

closes #20

should likely be followed by openrewrite/rewrite-maven-plugin#110

Comment on lines -70 to +76
Task rewriteWarnAll = tasks.create("rewriteWarn", taskClosure(task -> {
Task rewriteDryRunAll = tasks.create("rewriteDryRun", taskClosure(task -> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the old "warn" name working for now, just in case someone uses it. Create another task named rewriteWarn that depends on rewriteDryRun. We'll leave the aliases in for a few releases

Copy link
Contributor Author

@aegershman aegershman Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify: are we just aliasing the command rewriteWarn, or do we also need to alias rewriteWarn{SourceSet}, e.g. users running rewriteWarnTest, rewriteWarnMain, etc.?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just rewriteWarn. I think it unlikely that anyone will have bothered with the more granular per-sourceSet tasks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for good measure I included the specific source sets, too.

@aegershman aegershman force-pushed the rewriteWarn-to-rewriteDryRun branch from 984a0b8 to b363c0a Compare April 1, 2021 21:40
@aegershman aegershman marked this pull request as ready for review April 1, 2021 21:44
@aegershman aegershman force-pushed the rewriteWarn-to-rewriteDryRun branch from b363c0a to 0e52673 Compare April 1, 2021 22:12
@aegershman aegershman changed the title rewriteWarn refactored to rewriteDryRun rename tasks rewriteWarn to rewriteDryRun and rewriteFix to rewriteRun Apr 1, 2021
@aegershman aegershman requested a review from sambsnyd April 1, 2021 22:18
@aegershman
Copy link
Contributor Author

(going to close this PR outright and will open a separate one renaming both rewriteWarn and rewriteFix in the same PR and without aliasing)

@aegershman aegershman closed this Apr 5, 2021
@aegershman aegershman deleted the rewriteWarn-to-rewriteDryRun branch April 5, 2021 17:57
@aegershman aegershman added the wontfix This will not be worked on label Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename tasks rewriteWarn to rewriteDryRun and rewriteFix to rewriteRun
2 participants