Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update Gradle wrapper #295

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Conversation

shanman190
Copy link
Collaborator

@shanman190
Copy link
Collaborator Author

The UserInputHandler class has had some modifications for Gradle 8.7 as it appears the Gradle team is beginning to clean up the API a bit in an effort to make a public API version of the feature available. This will presently require a version check to make the OpenRewrite plugin compatible with the new version.

@timtebeek
Copy link
Contributor

Adding the details here to save others a click:

Compiling with JDK Java compiler API.
/home/runner/work/rewrite-gradle-plugin/rewrite-gradle-plugin/plugin/src/main/java/org/openrewrite/gradle/isolated/ui/RecipeDescriptorTreePrompter.java:62: error: cannot find symbol
                prompted = prompter.askQuestion(query.toString(), "");
                                   ^
  symbol:   method askQuestion(String,String)
  location: variable prompter of type UserInputHandler

String prompted;
query.append(CHOOSE_NUMBER_PROMPT);
do {
prompted = prompter.askQuestion(query.toString(), "");

@shanman190
Copy link
Collaborator Author

I'm honestly kinda surprised that more folks haven't reported this issue. It kinda makes me think that the rewriteDiscover task tends to not be utilized at all.

@timtebeek
Copy link
Contributor

Yes I'm thinking the same: that task and the equivalent in the Maven plugin are likely not used much, if at all. They can be useful when troubleshooting I suppose, but there's less of a need for that now that we suggest the closest match too

We could remove these if we don't feel like maintaining these goals going forward. I doubt a knowledgeable user would need them, nor if a novice use would find them.

timtebeek added a commit that referenced this pull request Aug 3, 2024
Likely unused and somewhat problematic in newer Gradle versions; removed here for simplicity.

See also: #295
shanman190 pushed a commit that referenced this pull request Aug 3, 2024
Likely unused and somewhat problematic in newer Gradle versions; removed here for simplicity.

See also: #295
@timtebeek timtebeek merged commit 945ec61 into main Aug 3, 2024
1 check passed
@timtebeek timtebeek deleted the refactor/update-gradle-wrapper branch August 3, 2024 17:49
@timtebeek timtebeek restored the refactor/update-gradle-wrapper branch August 3, 2024 17:49
@timtebeek timtebeek deleted the refactor/update-gradle-wrapper branch August 3, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants