Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding nebula.maven-apache-license plugin to inject license metadata … #308

Merged
merged 1 commit into from
May 24, 2024
Merged

adding nebula.maven-apache-license plugin to inject license metadata … #308

merged 1 commit into from
May 24, 2024

Conversation

nmck257
Copy link
Contributor

@nmck257 nmck257 commented May 24, 2024 •
edited by timtebeek
Loading

…into plugin's pom

What's changed?

The plugin's generated pom (but not necessarily the plugin marker artifact) should now include the license metadata

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@nmck257 nmck257 mentioned this pull request May 24, 2024
Closed
@jkschneider jkschneider merged commit 58be01e into openrewrite:main May 24, 2024
1 check passed
@nmck257 nmck257 deleted the feature/305 branch May 25, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanman190 shanman190 shanman190 approved these changes

@jkschneider jkschneider jkschneider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nmck257 @jkschneider @shanman190