Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SourceFile implementations should include default SearchResultPrinters #412

Closed
sambsnyd opened this issue Apr 1, 2021 · 0 comments
Closed

SourceFile implementations should include default SearchResultPrinters #412

sambsnyd opened this issue Apr 1, 2021 · 0 comments
Assignees
@sambsnyd
Labels
enhancement New feature or request
Milestone
7.2.0

Comments

@sambsnyd
Copy link
Member

sambsnyd commented Apr 1, 2021

Currently we have no straightforward way of printing SearchResult markers when running via our build plugins.
This means that search recipes run but produce no visible output.
As a first step to fixing this, we need to have a default SearchResultPrinter for each type of SourceFile. These default search result printers must print markers inside of a context-appropriate comment so that reifying the markers to code changes doesn't result in broken code. e.g.: /* ~~> */ for Java and <!-- ~~> --> for XML
@sambsnyd sambsnyd added the enhancement New feature or request label Apr 1, 2021
@sambsnyd sambsnyd added this to the 7.2.0 milestone Apr 1, 2021
This was referenced Apr 1, 2021
Closed
Closed
@sambsnyd sambsnyd self-assigned this Apr 3, 2021
sambsnyd added a commit that referenced this issue Apr 3, 2021
@sambsnyd
Add default search result marker printers to SourceFile types that su…
912894e 
…pport inline comments. Fixes #412
sambsnyd added a commit that referenced this issue Apr 6, 2021
@sambsnyd
Make markers responsible for printing themselves. Fixes #412
9441200
sambsnyd added a commit that referenced this issue Apr 6, 2021
@sambsnyd
Add default search result marker printers to SourceFile types that su…
fd9f5eb 
…pport inline comments. Fixes #412
sambsnyd added a commit that referenced this issue Apr 6, 2021
@sambsnyd
Make markers responsible for printing themselves. Fixes #412
d3e4a47
sjungling pushed a commit that referenced this issue Feb 3, 2023
@timtebeek
#412 Added Operating System Marker to Rewrite (#2766)
f923437 
* added Operating System marker

* Add license

---------

Co-authored-by: Reagan Karnes <reagan@moderne.io>
Co-authored-by: Tim te Beek <timtebeek@gmail.com>
reka18 added a commit that referenced this issue Feb 6, 2023
@reka18
#412 Implemented Marker in OperatingSystem (#2794)
1ee3392 
* <reka18> implemented Marker in OperatingSystem

* <reka18> cleanup
sambsnyd pushed a commit to yeikel/rewrite that referenced this issue Feb 10, 2023
@reka18 @sambsnyd
openrewrite#412 Implemented Marker in OperatingSystem (openrewrite#2794)
ba2005d 
* <reka18> implemented Marker in OperatingSystem

* <reka18> cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sambsnyd sambsnyd

Labels
enhancement New feature or request
Projects
None yet
Milestone
7.2.0
Development

No branches or pull requests
1 participant
@sambsnyd