Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RenameVariable and RenamePrivateFieldsToCamelCase (Issue: #2285) #2292

Merged
merged 2 commits into from
Oct 8, 2022
Merged

Fix RenameVariable and RenamePrivateFieldsToCamelCase (Issue: #2285) #2292

merged 2 commits into from
Oct 8, 2022

Conversation

pway99
Copy link
Contributor

@pway99 pway99 commented Oct 7, 2022

  • inner-class variable references
  • NamedVariable existing in multiple scopes

TODO:

  • support for ParameterizedTypes
  • RewriteTest conversions

@pway99
Fix RenameVariable and RenamePrivateFieldsToCamelCase (Issue: #2285)
cd1249e 
 - inner-class variable references
 - NamedVariable existing in multiple scopes

Still needs update for ParameterizedTypes
@pway99
support ParameterizedTypes
1ed12c1
@sambsnyd sambsnyd merged commit 795823b into main Oct 8, 2022
@sambsnyd sambsnyd deleted the rename-variable-2285 branch October 8, 2022 00:13
@pway99 pway99 mentioned this pull request Oct 10, 2022
Closed
@pway99 pway99 added this to the 7.31.0 milestone Oct 10, 2022
@tkvangorder tkvangorder added the bug Something isn't working label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
7.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pway99 @tkvangorder @sambsnyd